Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add authorization to endorsement API #36

Open
wants to merge 11 commits into
base: f24
Choose a base branch
from

Conversation

vickyc2266
Copy link

@vickyc2266 vickyc2266 commented Oct 11, 2024

Attempted to resolve #26

Attempted to debug the ability for authentication with the endorsement feature of posts. Found that a potential reason for the test failure for the endorse posts feature could be because of undefined uid throughout different files that have to do with the endorsement feature in files such as src/socket.io/posts/tools.js, src/api/posts.js, test/helpers/index.js, test/socket.io.js, and etc

Screenshot 2024-10-10 at 11 36 12 PM
Screenshot 2024-10-10 at 11 36 43 PM

The following files were gone through and edited:
src/api/posts.js
src/posts/endorsement.js
src/privileges/posts.js
src/socket.io/posts/tools.js
test/helpers/index.js
test/posts.js
test/socket.io.js

@vickyc2266 vickyc2266 added bug Something isn't working incomplete issues that were not successfully completed labels Oct 11, 2024
@vickyc2266 vickyc2266 added this to the Sprint 2 milestone Oct 11, 2024
@vickyc2266 vickyc2266 changed the title Vicky's merge attempt to debug endorse feature #26 Attempt to add authorization to endorsement API #26 Oct 11, 2024
@vickyc2266 vickyc2266 changed the title Attempt to add authorization to endorsement API #26 Attempt to add authorization to endorsement API Oct 11, 2024
@evelynnchen-cmu
Copy link

Due to implementation not working 100% and incoming merge conflicts, we will not be accepting this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working incomplete issues that were not successfully completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing only professors/TAs to endorse a post
2 participants